Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove USE_EE & USE_GE analysis keywords #6576

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Nov 15, 2023

Remove silent handling of removed/deprecated keywords, and rather raise ConfigValidationError instead.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@andreas-el andreas-el self-assigned this Nov 15, 2023
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 15, 2023
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! 🧹

@andreas-el andreas-el merged commit 26d478c into equinor:main Nov 16, 2023
44 checks passed
@andreas-el andreas-el deleted the remove_use_ee_ge_keyword_handling branch November 16, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants