Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out deprecation warnings from main entry point #7133

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Feb 8, 2024

Issue
Resolves #7051

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (66412cf) 83.73% compared to head (c24d0b2) 85.25%.
Report is 31 commits behind head on main.

Files Patch % Lines
src/ert/services/_storage_main.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7133      +/-   ##
==========================================
+ Coverage   83.73%   85.25%   +1.51%     
==========================================
  Files         367      379      +12     
  Lines       22138    22572     +434     
  Branches     1011     1032      +21     
==========================================
+ Hits        18538    19243     +705     
+ Misses       3286     3217      -69     
+ Partials      314      112     -202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Feb 8, 2024
@oyvindeide oyvindeide merged commit de7c7ed into equinor:main Feb 8, 2024
51 checks passed
@oyvindeide oyvindeide deleted the filter_warnings branch February 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lot of deprecation warnings are printed to terminal when plotting from poly example
4 participants