-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure SummaryConfig cannot be created with no keys #7150
Ensure SummaryConfig cannot be created with no keys #7150
Conversation
0fb444f
to
c29b7b2
Compare
47a573d
to
46953f1
Compare
46953f1
to
6da9b91
Compare
6da9b91
to
a5b5745
Compare
0831be9
to
728aea3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7150 +/- ##
==========================================
+ Coverage 84.71% 85.41% +0.69%
==========================================
Files 380 380
Lines 22633 22631 -2
Branches 931 936 +5
==========================================
+ Hits 19174 19330 +156
+ Misses 3340 3183 -157
+ Partials 119 118 -1 ☔ View full report in Codecov by Sentry. |
@frode-aarstad This cannot be merged currently though as it would break with current behavior that ert/src/ert/config/observations.py Lines 110 to 111 in 1ff65a5
|
728aea3
to
58cf54f
Compare
58cf54f
to
0037825
Compare
Resolves #7046
When applicable