Have lsf driver log missing jobid in kill to debug instead of error #7944
Conversation
jonathan-eq
added
maintenance
|
I think this is an actual bug that this code (before and after the PR) hides. If we issue |
Okay, so as I understand it; we are potentially trying to kill a job before qsub has been called, or has not finished, or we havent processed the qsub output to get jobid. |
| @@ -204,8 +208,8 @@ def __init__( | |||
| self._bjobs_cmd = Path(bjobs_cmd or shutil.which("bjobs") or "bjobs") | |||
| self._bkill_cmd = Path(bkill_cmd or shutil.which("bkill") or "bkill") | |||
|
|
|||
| self._jobs: MutableMapping[str, JobData] = {} | |||
| self._iens2jobid: MutableMapping[int, str] = {} | |||
| self._iens2jobdata: MutableMapping[int, JobData] = {} | |||
There was a problem hiding this comment.
why change iens from str to int in this pr?
| job_id: Optional[str] = None | ||
| job_state: Optional[AnyJob] = None | ||
| submitted_timestamp: Optional[float] = None | ||
| submitted_future: asyncio.Future[bool] = Field(default_factory=asyncio.Future) |
There was a problem hiding this comment.
"submitted" is a little bit ambigous, it could be after submit() is called, or when when bsub is called, or when bsub is finished etc. Maybe submit_function_finished or something better?
There was a problem hiding this comment.
Think about how this will be for resubmissions.
If it interferes with that, maybe we need a lock mechanism instead, "submit_is_in_progress" ?
|
Closing this as the original issue has been reformulated and have gotten a scope increase. |
Issue
Resolves #7907
Approach
馃敘
(Screenshot of new behavior in GUI if applicable)
When applicable