Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created at for experiment in GUI #7981

Merged
merged 1 commit into from
May 27, 2024

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented May 27, 2024

Issue
Resolves #7950

image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:bug-fix Automatically categorise as bug fix in release notes label May 27, 2024
@frode-aarstad frode-aarstad self-assigned this May 27, 2024
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you also add a screenshot to the description for the release notes? I reviewed the other commit in another PR, there is a small change to be made to that, so good to fix that before merging this.

@frode-aarstad
Copy link
Contributor Author

LGTM! Could you also add a screenshot to the description for the release notes? I reviewed the other commit in another PR, there is a small change to be made to that, so good to fix that before merging this.

Rebased

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.75%. Comparing base (23fc482) to head (ad42542).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7981      +/-   ##
==========================================
- Coverage   85.76%   85.75%   -0.01%     
==========================================
  Files         378      378              
  Lines       23103    23108       +5     
  Branches      636      627       -9     
==========================================
+ Hits        19814    19817       +3     
- Misses       3216     3217       +1     
- Partials       73       74       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frode-aarstad frode-aarstad merged commit 706806d into equinor:main May 27, 2024
38 checks passed
@frode-aarstad frode-aarstad deleted the add-experiment-time branch May 27, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage Experiments Created At column empty
3 participants