Reduce use of enseble by name #7995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
reduce-use-of-enseble-by-name
branch
2 times, most recently
from
3982927
to
37f6645
Compare
frode-aarstad
force-pushed
the
reduce-use-of-enseble-by-name
branch
from
37f6645
to
93eb85c
Compare
dafeda
reviewed
May 29, 2024
| help="Name of the ensemble where the results for the experiment " | ||
| dest="restart_ensemble_id", | ||
| help="Deprecated: This argument is deprecated and will be " | ||
| "removed in future versions. Use --restart-ensemble-id instead.", |
There was a problem hiding this comment.
Are we sure we want users to specify an id instead of a name, as it's tricky to find the id of ensembles.
There was a problem hiding this comment.
I agree the uuids for an ensemble is hard to find. Discussed this with @oyvindeide and we agreed that this change is ok as it is in a setting that is used by more advanced users
dafeda
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #7893
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable