Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Map (overview of process) #473

Closed
knudsvik opened this issue Jan 23, 2023 · 17 comments · Fixed by #735 or #742
Closed

Feat: Map (overview of process) #473

knudsvik opened this issue Jan 23, 2023 · 17 comments · Fixed by #735 or #742
Assignees
Labels
feat New feature or request feedback Originated from user feedback

Comments

@knudsvik
Copy link
Contributor

User input 3 (by Lise Storhaug Ekeland, Geir Lea Berge, Henriette Eidsnes):
Vanskelig å se /få oversikt over totalprosess/flyt når vi jobber i systemet.. Kun fokus der vi er og vanskelig å få en rød tråd  => mulig å ha med et lite bilde av hele prosessen I bakgrunnen?

Possible solution:
See map in Miro

@knudsvik knudsvik added feat New feature or request feedback Originated from user feedback labels Jan 23, 2023
@VetleW VetleW mentioned this issue May 6, 2024
@VetleW
Copy link

VetleW commented May 6, 2024

New design
connected to design of #295

@QiJin-Bouvet QiJin-Bouvet changed the title Map (overview of process) Feat: Map (overview of process) May 13, 2024
@HavardNot HavardNot self-assigned this May 21, 2024
@HavardNot HavardNot linked a pull request May 21, 2024 that will close this issue
@HavardNot
Copy link
Contributor

Seems there is limited options as far as styling goes, using the standard styling setup for React-Flow looks like:

Image

@VetleW
Copy link

VetleW commented May 22, 2024

What options are there? @HavardNot

@nesadrian
Copy link
Contributor

nesadrian commented May 22, 2024

I think we should have a border around the minimap, otherwise it ends up looking out of place when you pan the camera away from the process like in the screenshot below. Here is a list of the options we have @VetleW. The cards and lines has a lot of customization options, but otherwise it's pretty limited, like Håvard said. You can check it out in DEV
Image

@VetleW
Copy link

VetleW commented May 22, 2024

I agree on the border. Would love for it to look something like this :) (Figma link)
Screenshot 2024-05-22 at 16 08 18

@HavardNot
Copy link
Contributor

Managed to wrestle with the CSS to create this. Will create a separate issue for zoom percentage as it was a bit complicated to handle updating the value when the user zooms with the mouse/trackpad. The zoom value will probably be placed to the right of the controls instead of between "+" and "-" as it is not a native feature of the "Control" component from React-Flow

image

@VetleW
Copy link

VetleW commented May 23, 2024

Possible to change the fullscreen icon to fit to screen icon as well?
It isn't really a fullscreen button, rather a center or fit to screen button.

@HavardNot
Copy link
Contributor

HavardNot commented May 23, 2024

It is possible but it is not a good idea. React Flow does not expose the ability to override the icon in the API, it only has support for adding more buttons. so i would have to hide the original button by using CSS and then creating a custom button with the same functionality but with the new icon. Which i think is too much work for such a small change.

A quick fix alternative is to use Javascript logic to manipulate the DOM during run-time. However, Circumventing the React virtual DOM is considered bad practice and should be avoided as it easily breaks. I got it working, though the icon is a bit small

Image

@nesadrian
Copy link
Contributor

One small detail: I think we should remove the gap and border of the buttons so that the design will be more consistent with the other button group. What do you think @VetleW @HavardNot ?
image
image

@HavardNot
Copy link
Contributor

Fixed hover color and removed the border shadow between the buttons
image

@HavardNot
Copy link
Contributor

Ready for test in web-flyt-test.radix.equinor.com @QiJin-Bouvet

@QiJin-Bouvet
Copy link

QiJin-Bouvet commented May 24, 2024

Tested in TEST env.

  • Mini map shows the focus area with a border
  • Changes in canvas get updated in mini map

BUT, some edges/lines are shown as green card in mini map by mistake.

image

@QiJin-Bouvet
Copy link

Tested in TEST env.
Mini map shows the focus area correctly.

Image

@QiJin-Bouvet
Copy link

Tested in QA env.
Mini map shows the choice card as normal sub activity card. Need a fix.

@HavardNot
Copy link
Contributor

Fixed choice card minimap node displaying incorrectly. ready for test https://web-flyt-test.radix.equinor.com/ @QiJin-Bouvet

@QiJin-Bouvet
Copy link

Tested in TEST env.
The mini map works as expected.

HavardNot added a commit that referenced this issue May 29, 2024
@QiJin-Bouvet
Copy link

Tested in QA env.
The mini map works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request feedback Originated from user feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants