Aggregation_id #222
Merged
Aggregation_id #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrivenaes
reviewed
Jul 4, 2022
src/fmu/dataio/dataio.py
Outdated
Comment on lines
935
to
937
| aggregation_id: Give an explicit ID for the aggregation. If None, or not | ||
| provided, an automatic ID based on existing realization uuid will be made. | ||
| Default is None which means it will be missing (null) in the metadata. |
There was a problem hiding this comment.
Something is self-contradicting here. What will None actually give?
jcrivenaes
reviewed
Jul 4, 2022
src/fmu/dataio/dataio.py
Outdated
| stringinput += xuuid | ||
|
|
||
| return uuid_from_string(stringinput) | ||
| return str(uuid_from_string(stringinput)) |
There was a problem hiding this comment.
Perhaps it would be better if the uuid_from_string function do the str() conversion
jcrivenaes
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #221
aggregation_idaggregation_idis now a stringaggregation_idis now independent of sorting (same input give same output, regardless of input sorting)