Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate fmu.ensemble.etc for API compatibility #193

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Conversation

berland
Copy link
Collaborator

@berland berland commented Jan 19, 2021

Resolves #192

@ertomatic
Copy link

Can one of the admins verify this patch?

@markusdregi
Copy link

@berland: Any reason you are not introducing all of the etc module?

Besides that, the deprecation and testing of it is good 👏

@berland
Copy link
Collaborator Author

berland commented Jan 19, 2021

It is unlikely that there are user-scripts with anything else than what was in the documention, that is why I chose to only ensure that did not crash. I choose to not replicate exact logging behavior, rather trigger people to maintain their code.

@markusdregi
Copy link

Aight, if that was the only documented method I'm willing to accept that that was the only public part of the API... But, deprecated methods typically still function as expected. Are you sure you do not want to either introduce the old implementation of the function, or raise an exception instead of the deprecation warning?

@berland
Copy link
Collaborator Author

berland commented Jan 19, 2021

Aight, fully reinstated original code from v1.4.0, but with depr waraning. I envisioned it would trip other code, but it did not.

Copy link

@markusdregi markusdregi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@berland berland merged commit 7bb828f into master Jan 20, 2021
@berland berland deleted the reinstateetc branch January 20, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

submodule etc is missing
3 participants