Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate functions that are planned removed in v2.0.0 #202

Merged
merged 6 commits into from
Feb 23, 2021

Conversation

berland
Copy link
Collaborator

@berland berland commented Feb 1, 2021

See #191

@berland berland requested a review from asnyv February 1, 2021 12:36
@berland berland changed the title Deprecate function that are planned removed in v2.0.0 Deprecate functions that are planned removed in v2.0.0 Feb 1, 2021
@asnyv
Copy link
Collaborator

asnyv commented Feb 1, 2021

Use DeprecationWarning instead?

@berland
Copy link
Collaborator Author

berland commented Feb 1, 2021

Use DeprecationWarning instead?

DeprecationWarnings are by default not visible to users, according to Python docs they are meant for developers. FutureWarning is by default visible to users.

@asnyv
Copy link
Collaborator

asnyv commented Feb 1, 2021

Use DeprecationWarning instead?

DeprecationWarnings are by default not visible to users, according to Python docs they are meant for developers. FutureWarning is by default visible to users.

Well, that was part of the point 😅

@asnyv
Copy link
Collaborator

asnyv commented Feb 1, 2021

fmu-ensemble tends to write many warnings considering the iterative nature of it 😬

@berland
Copy link
Collaborator Author

berland commented Feb 1, 2021

fmu-ensemble tends to write many warnings considering the iterative nature of it

Yes, this patch has not been tried live. It might emit one warning pr. realization, but if that causes user action, it is the intention..

@codecov-io
Copy link

codecov-io commented Feb 22, 2021

Codecov Report

Merging #202 (c8e8885) into master (82cf5fa) will increase coverage by 0.11%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   82.96%   83.08%   +0.11%     
==========================================
  Files          14       14              
  Lines        2930     2986      +56     
==========================================
+ Hits         2431     2481      +50     
- Misses        499      505       +6     
Impacted Files Coverage Δ
src/fmu/ensemble/ensembleset.py 78.68% <62.50%> (-0.52%) ⬇️
src/fmu/ensemble/ensemble.py 86.48% <91.30%> (+0.20%) ⬆️
src/fmu/ensemble/realization.py 86.60% <94.73%> (+0.25%) ⬆️
src/fmu/ensemble/virtualensemble.py 84.66% <100.00%> (+0.10%) ⬆️
src/fmu/ensemble/virtualrealization.py 88.93% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82cf5fa...c8e8885. Read the comment docs.

src/fmu/ensemble/ensembleset.py Outdated Show resolved Hide resolved
src/fmu/ensemble/ensembleset.py Outdated Show resolved Hide resolved
src/fmu/ensemble/realization.py Outdated Show resolved Hide resolved
src/fmu/ensemble/realization.py Outdated Show resolved Hide resolved
@asnyv
Copy link
Collaborator

asnyv commented Feb 22, 2021

LGTM 👍

@berland berland requested a review from asnyv February 23, 2021 07:19
@berland berland merged commit 868bc9d into equinor:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing functionality for fmu-ensemble 2.0
3 participants