-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate functions that are planned removed in v2.0.0 #202
Conversation
Use DeprecationWarning instead? |
DeprecationWarnings are by default not visible to users, according to Python docs they are meant for developers. FutureWarning is by default visible to users. |
b5effb7
to
2e2d8af
Compare
Well, that was part of the point 😅 |
fmu-ensemble tends to write many warnings considering the iterative nature of it 😬 |
Yes, this patch has not been tried live. It might emit one warning pr. realization, but if that causes user action, it is the intention.. |
3cf4403
to
3f4f287
Compare
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 82.96% 83.08% +0.11%
==========================================
Files 14 14
Lines 2930 2986 +56
==========================================
+ Hits 2431 2481 +50
- Misses 499 505 +6
Continue to review full report at Codecov.
|
2c80673
to
2f56bef
Compare
2f56bef
to
fdf7732
Compare
fdf7732
to
a6ec83c
Compare
LGTM 👍 |
See #191