Repo setup #28
Merged
Repo setup #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the qcforward commits be separated out in its own PR? (at least if we are going to do some rebasing) |
tralsos
reviewed
Mar 23, 2020
|
|
||
| * Docstrings shall start and end with """ and use Google style. | ||
|
|
||
| * Use pytest as testing engine | ||
|
|
||
| * Code shall be be Python 2.7.13 + and python 3.4 + compliant | ||
| * Code shall be Python 2.7.13 + (until mid 2020) and python 3.4 + compliant |
There was a problem hiding this comment.
Yes perhaps, but the difference between 2.7.13 and 2.7.14 are not noticable for most users I will think (bug fixes on nitty-gritty details)
tnatt
approved these changes
Mar 23, 2020
berland
pushed a commit
that referenced
this pull request
Jun 11, 2020
* Simplify setup, change form versioneer to setuptools_scm * Edit ignore list * Line length 88 as black * Improve/change setup and versioning system * Disabled Makefile * Clean up generated files and do a code blackening * Added requirements in setup * Changed version system * Added message control list * Improve and correct text * Added doc page for qcforward * Corrected versioning and added qcforward * wip: QCForward class * Blacken code * Added initial test for qcforward
berland
pushed a commit
that referenced
this pull request
Jun 17, 2020
* Simplify setup, change form versioneer to setuptools_scm * Edit ignore list * Line length 88 as black * Improve/change setup and versioning system * Disabled Makefile * Clean up generated files and do a code blackening * Added requirements in setup * Changed version system * Added message control list * Improve and correct text * Added doc page for qcforward * Corrected versioning and added qcforward * wip: QCForward class * Blacken code * Added initial test for qcforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.