Rename to grid3d-maps #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrivenaes
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Perhaps an discussion we should finish outside; I after some thoughts/maturation I think grid3d-maps will be a better name. Two reasons (1): More in line with current name and (2): The word "surfaces" for many refers to "terrain/geometry", while the operations here are actually mapping reservoir properties in a 3D grid to either averages or cumulative entities.
mferrera
force-pushed
the
rename-package
branch
from
afd4234
to
6bddae2
Compare
|
I'll put both versions here and squash or drop when we decide; I am also in favor of grid3d-maps. |
mferrera
force-pushed
the
rename-package
branch
from
6bddae2
to
9651e50
Compare
mferrera
force-pushed
the
rename-package
branch
from
9651e50
to
c2f902a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will have to ignore the failing ERT workflows for now as the version on PyPI is missing a dependency.