Correct dataio issues etc v2 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrivenaes
force-pushed
the
correct-dataio-issues-etc-v2
branch
from
cad921b
to
26edb32
Compare
| def _get_global_config(thisconfig): | ||
| """Get the global config in different manners. Priority: | ||
|
|
||
| (1) A setting inside the setup file: input: fmu_global_config: will win if present |
There was a problem hiding this comment.
Would it make sense to change the order? I.e. first the explicit environment variable, then the more generic environment variable and lastly the (most generic) file? Don't know the answer.
There was a problem hiding this comment.
I was thinking through this, back and forth, and I think this is most logical. However, we need to revisit the order in fmu.dataio also.
perolavsvendsen
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Assume this is fine 👍🏻 Minor comments:
- Order of config lookup. Now first file, then generic environment variable, then lastly explicit environment variable. Will it make sense to reverse this?
- No tests for this lookup, e.g. if given a file, will it ignore the environment variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input.fmu_global_config.