added careful copy job with corresponding test. #424
Conversation
|
Can one of the admins verify this patch? |
|
Ok to test |
python/res/fm/shell/shell.py
Outdated
| @staticmethod | ||
| def carefulCopyFile(src , target = None): | ||
| if os.path.exists(target): | ||
| raise IOError("Input argument:'%s' already exist" % target) |
There was a problem hiding this comment.
That the target file exists is perfectly OK - not exception.
python/res/fm/shell/shell.py
Outdated
| @staticmethod | ||
| def carefulCopyFile(src , target = None): | ||
| if os.path.exists(target): | ||
| raise IOError("Input argument:'%s' already exist" % target) |
There was a problem hiding this comment.
That the target file exists is perfectly OK - not exception.
There was a problem hiding this comment.
Should the function fail silently? Would it not be a good idea to let the user know if the copy failed?
There was a problem hiding this comment.
Well - if the file is already present the copy should not proceed, and that is the expected operation of this function - i.e. not a failure. Could add a message like:
print("File: {} already present - not updated".format(target_file))
There was a problem hiding this comment.
Very good, I will change it accordingly.
| @@ -0,0 +1,9 @@ | |||
| STDOUT careful_copy_file.stdout | |||
| STDERR careful_copy_file.stderr | |||
There was a problem hiding this comment.
The std file descriptors are redirected by default - not necessary to do it explicitly.
Printing warning when file exist Changed unit test of careful_copy_file accordingly
Task
#416
Approach
Short description of the approach
Pre un-WIP checklist
Depends on