* refact: don't log the exception message before raising exception (#743

) * refact: don't log the exception message before raising
equinor · Jun 17, 2023 · 15772fd · 15772fd
1 parent 13266ec
commit 15772fd
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 18 deletions.
diff --git a/...im/processSimulation/processEquipment/compressor/CompressorChartAlternativeMapLookup.java b/...im/processSimulation/processEquipment/compressor/CompressorChartAlternativeMapLookup.java
@@ -191,7 +191,6 @@ public CompressorCurve getCurveAtRefSpeed(double refSpeed) {
       }
     }
     String msg = "Does not match any speed in the chart.";
-    logger.error(msg);
     neqsim.util.exception.InvalidInputException ex =
         new neqsim.util.exception.InvalidInputException(this, "getCurveAtRefSpeed", "refSpeed",
             msg);

diff --git a/src/main/java/neqsim/thermo/component/Component.java b/src/main/java/neqsim/thermo/component/Component.java
@@ -495,7 +495,6 @@ public Component clone() {
   public void addMolesChemReac(double dn, double totdn) {
     if (numberOfMoles + totdn < 0 || numberOfMolesInPhase + dn < 0) {
       String msg = "will lead to negative number of moles of component in phase";
-      logger.error(msg);
       neqsim.util.exception.InvalidInputException ex =
           new neqsim.util.exception.InvalidInputException(this, "addMolesChemReac", "dn", msg);
       throw new RuntimeException(ex);

diff --git a/src/main/java/neqsim/thermo/phase/Phase.java b/src/main/java/neqsim/thermo/phase/Phase.java
@@ -175,7 +175,6 @@ public void addMoles(int component, double dn) {
   public void addMolesChemReac(int component, double dn, double totdn) {
     if ((numberOfMolesInPhase + dn) / numberOfMolesInPhase < -1e-10) {
       String msg = "will lead to negative number of moles in phase." + (numberOfMolesInPhase + dn);
-      logger.error(msg);
       neqsim.util.exception.InvalidInputException ex =
           new neqsim.util.exception.InvalidInputException(this, "addMolesChemReac", "dn", msg);
       throw new RuntimeException(ex);

diff --git a/src/main/java/neqsim/thermo/system/SystemThermo.java b/src/main/java/neqsim/thermo/system/SystemThermo.java
@@ -166,17 +166,13 @@ public SystemThermo() {
   public SystemThermo(double T, double P) {
     this();
     if (T < 0.0) {
-      String msg = "Negative input temperature";
-      logger.error(msg);
       neqsim.util.exception.InvalidInputException ex =
           new neqsim.util.exception.InvalidInputException(this.getClass().getSimpleName(),
               "SystemThermo", "T", "is negative");
       throw new RuntimeException(ex);
     }
 
     if (P < 0.0) {
-      String msg = "Negative input pressure";
-      logger.error(msg);
       neqsim.util.exception.InvalidInputException ex =
           new neqsim.util.exception.InvalidInputException(this.getClass().getSimpleName(),
               "SystemThermo", "P", "is negative");
@@ -777,14 +773,10 @@ public void addSalt(String componentName, double value) {
   public void addTBPfraction(String componentName, double numberOfMoles, double molarMass,
       double density) {
     if (density < 0.0) {
-      String msg = "Negative input density.";
-      logger.error(msg);
       throw new RuntimeException(new neqsim.util.exception.InvalidInputException(this,
           "addTBPfraction", "density", "is negative."));
     }
     if (molarMass < 0.0) {
-      String msg = "Negative input molar mass.";
-      logger.error(msg);
       throw new RuntimeException(new neqsim.util.exception.InvalidInputException(this,
           "addTBPfraction", "molarMass", "is negative."));
     }
@@ -922,15 +914,11 @@ public void addTBPfraction(String componentName, double numberOfMoles, double mo
   public void addTBPfraction(String componentName, double numberOfMoles, double molarMass,
       double density, double criticalTemperature, double criticalPressure, double acentricFactor) {
     if (density < 0.0 || molarMass < 0.0) {
-      String msg = "Negative input density.";
-      logger.error(msg);
       throw new RuntimeException(new neqsim.util.exception.InvalidInputException(this,
           "addTBPfraction", "density", "is negative."));
     }
 
     if (density < 0.0 || molarMass < 0.0) {
-      String msg = "Negative input molar mass.";
-      logger.error(msg);
       throw new RuntimeException(new neqsim.util.exception.InvalidInputException(this,
           "addTBPfraction", "molarMass", "is negative."));
     }
@@ -1144,8 +1132,7 @@ public void addComponent(String componentName, double moles) {
         throw new RuntimeException("No component with name: " + componentName + " in database");
       }
       if (moles < 0.0) {
-        String msg = "Negative input number of moles of component: " + componentName;
-        logger.error(msg);
+        String msg = "is negative input for component: " + componentName;
         throw new RuntimeException(
             new neqsim.util.exception.InvalidInputException(this, "addComponent", "moles", msg));
       }
@@ -1248,7 +1235,6 @@ public void addComponent(String componentName, double moles, int phaseNumber) {
     // Add new component
     if (moles < 0.0) {
       String msg = "Negative input number of moles.";
-      logger.error(msg);
       neqsim.util.exception.InvalidInputException ex =
           new neqsim.util.exception.InvalidInputException(this, "addComponent", "moles", msg);
       throw new RuntimeException(ex);