Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added exceptions for units not supported #1010

Merged
merged 15 commits into from
May 10, 2024
Merged

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented May 10, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 78.46890% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 35.65%. Comparing base (d11480e) to head (26dd058).

Files Patch % Lines
...c/main/java/neqsim/thermo/component/Component.java 56.25% 6 Missing and 1 partial ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 0.00% 6 Missing ⚠️
...imulation/util/monitor/FluidComponentResponse.java 86.84% 5 Missing ⚠️
.../processSimulation/util/monitor/FluidResponse.java 95.19% 5 Missing ⚠️
...a/neqsim/processSimulation/util/report/Report.java 16.66% 4 Missing and 1 partial ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 61.53% 4 Missing and 1 partial ⚠️
...cessSimulation/util/monitor/SeparatorResponse.java 42.85% 4 Missing ⚠️
...tion/util/monitor/ThreePhaseSeparatorResponse.java 0.00% 4 Missing ⚠️
src/main/java/neqsim/util/unit/Units.java 84.61% 1 Missing and 1 partial ⚠️
...rc/main/java/neqsim/thermo/phase/PhaseDefault.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1010      +/-   ##
============================================
+ Coverage     35.53%   35.65%   +0.12%     
- Complexity     5442     5461      +19     
============================================
  Files           705      706       +1     
  Lines         70146    70276     +130     
  Branches       8064     8066       +2     
============================================
+ Hits          24925    25059     +134     
+ Misses        43682    43679       -3     
+ Partials       1539     1538       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit d4b356c into master May 10, 2024
9 checks passed
@EvenSol EvenSol deleted the exception-when-wrong-units branch May 10, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants