Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test property flash #373

Merged
merged 81 commits into from
May 10, 2023

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@EvenSol
Copy link
Collaborator

EvenSol commented Apr 24, 2023

This is very good. The database has changed to H2, and some parameters in the model have been updated. So I guess this is the reason some test fails. We/I should go through the test to se it the failed test can be explained by the updated database parameters.

@asmfstatoil asmfstatoil marked this pull request as draft April 24, 2023 10:03
@asmfstatoil
Copy link
Collaborator Author

Set in draft mode while troubleshooting failed tests.

@EvenSol
Copy link
Collaborator

EvenSol commented Apr 24, 2023

The expected results from this test can be updated (probably because of some minor update of parameters):
ThermodynamicOperationsTest.testNeqSimPython2:79 array contents differ at index [5], expected: <4.910583053984447E-4> but was: <4.914277108631854E-4>

@asmfstatoil asmfstatoil marked this pull request as ready for review May 10, 2023 13:08
@asmfstatoil asmfstatoil merged commit 69eac26 into equinor:master May 10, 2023
@asmfstatoil asmfstatoil deleted the regression_test_propertyFlash branch May 10, 2023 15:03
asmfstatoil added a commit to asmfstatoil/neqsim that referenced this pull request May 19, 2023
* add regression test input
* test: disable failing test
EvenSol pushed a commit that referenced this pull request May 22, 2023
* add regression test input
* test: disable failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants