Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: replace use of phasetype as int with phasetype enum #928

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

asmfstatoil
Copy link
Collaborator

@asmfstatoil asmfstatoil commented Feb 23, 2024

remove deprecated System.
public default void init(double totalNumberOfMoles, int numberOfComponents, int type,
int ptNumber, double beta) {

@asmfstatoil asmfstatoil changed the title refact: replace use of phasetype as int refact: replace use of phasetype as int with phasetype enum Feb 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.68421% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 33.63%. Comparing base (6e6263c) to head (62da63b).

Files Patch % Lines
.../java/neqsim/thermo/mixingRule/EosMixingRules.java 20.00% 4 Missing ⚠️
...rc/main/java/neqsim/thermo/phase/PhaseDuanSun.java 0.00% 3 Missing ⚠️
src/main/java/neqsim/thermo/phase/PhaseGE.java 40.00% 3 Missing ⚠️
...eqsim/thermo/component/ComponentHydratePVTsim.java 0.00% 2 Missing ⚠️
...n/java/neqsim/thermo/component/ComponentSolid.java 33.33% 2 Missing ⚠️
...ava/neqsim/thermo/phase/PhaseGENRTLmodifiedWS.java 0.00% 2 Missing ⚠️
...c/main/java/neqsim/thermo/phase/PhaseGEUnifac.java 0.00% 2 Missing ⚠️
src/main/java/neqsim/thermo/phase/PhaseSrkCPA.java 0.00% 2 Missing ⚠️
...qsim/thermo/component/ComponentHydrateBallard.java 0.00% 1 Missing ⚠️
...va/neqsim/thermo/component/ComponentHydrateGF.java 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #928      +/-   ##
============================================
- Coverage     33.63%   33.63%   -0.01%     
+ Complexity     5126     5125       -1     
============================================
  Files           699      699              
  Lines         69788    69791       +3     
  Branches       7991     7991              
============================================
- Hits          23476    23474       -2     
- Misses        44836    44841       +5     
  Partials       1476     1476              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update👍

@asmfstatoil asmfstatoil merged commit 032c89c into equinor:master Feb 26, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the refact_phasetype branch February 26, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants