Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: systemthermo.initAnalytic #934

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil changed the title refact: systemthermo.initAnalytic(int type, int phase) refact: systemthermo.initAnalytic Feb 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 41.80328% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 33.69%. Comparing base (a8904b1) to head (e110d42).

Files Patch % Lines
...c/main/java/neqsim/thermo/system/SystemThermo.java 59.09% 4 Missing and 5 partials ⚠️
src/main/java/neqsim/thermo/phase/PhaseUMRCPA.java 0.00% 8 Missing ⚠️
...m/thermo/phase/PhaseSrkCPA_proceduralMatrices.java 0.00% 6 Missing ⚠️
...in/java/neqsim/thermo/phase/PhaseSrkCPAojAlgo.java 0.00% 6 Missing ⚠️
...t/ComponentModifiedFurstElectrolyteEosMod2004.java 0.00% 4 Missing and 1 partial ⚠️
...ain/java/neqsim/thermo/phase/PhaseGERG2004Eos.java 0.00% 4 Missing ⚠️
.../java/neqsim/thermo/component/ComponentCSPsrk.java 0.00% 3 Missing ⚠️
...rc/main/java/neqsim/thermo/phase/PhaseBWRSEos.java 0.00% 3 Missing ⚠️
.../main/java/neqsim/thermo/phase/PhaseCSPsrkEos.java 0.00% 3 Missing ⚠️
...va/neqsim/thermo/phase/PhaseElectrolyteCPAOld.java 0.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #934      +/-   ##
============================================
- Coverage     33.70%   33.69%   -0.01%     
+ Complexity     5131     5129       -2     
============================================
  Files           700      700              
  Lines         69764    69741      -23     
  Branches       7991     7984       -7     
============================================
- Hits          23512    23501      -11     
+ Misses        44774    44763      -11     
+ Partials       1478     1477       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! Both init method changes and initType make code better to read.

@asmfstatoil asmfstatoil merged commit db6cb52 into equinor:master Feb 27, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the refact_init branch February 27, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants