test: add tests

[asmfstatoil]

No description provided.

[EvenSol]

good test. All derivatives have not been implemented for PC-SAFT as you see.
Therefore properties requiring higher order derivatives might be wrong (eg. Cp), but I'm not sure. Fugacity and density should be ok. But I think how you have set it up is fine.

[asmfstatoil]

All the test values are fine at my mac, but the values found in the build env are quite different so that speaks of some numerical issues. Especially seen for higher order derivatives.

Regarding the non-implemented functions, my intent here was to add tests before removing the methods that are purely redundant copies of code in parent class phasepcsaft.java.

Interestingly I also saw that the phasepcsaftrahmat was in use for systempcsaft, not phasepcsaft

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.69%. Comparing base (db6cb52) to head (2df4975).

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #936      +/-   ##
============================================
+ Coverage     33.69%   34.69%   +0.99%     
- Complexity     5129     5274     +145     
============================================
  Files           700      700              
  Lines         69741    69741              
  Branches       7984     7984              
============================================
+ Hits          23501    24196     +695     
+ Misses        44763    44063     -700     
- Partials       1477     1482       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[EvenSol]

All the test values are fine at my mac, but the values found in the build env are quite different so that speaks of some numerical issues. Especially seen for higher order derivatives.

Regarding the non-implemented functions, my intent here was to add tests before removing the methods that are purely redundant copies of code in parent class phasepcsaft.java.

Interestingly I also saw that the phasepcsaftrahmat was in use for systempcsaft, not phasepcsaft

Yes - this is ok. The model was developed as part of the PhD thesis by Rhamat W.:
https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/2564750

[asmfstatoil]

Nice, be free to merge it when you are ready