Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: Phase classes clean up #941

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 34.69%. Comparing base (e7a90fb) to head (4297a56).
Report is 1 commits behind head on master.

Files Patch % Lines
...ava/neqsim/thermo/phase/PhaseGENRTLmodifiedWS.java 0.00% 2 Missing ⚠️
...c/main/java/neqsim/thermo/phase/PhaseGEUnifac.java 0.00% 2 Missing ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 0.00% 1 Missing ⚠️
...n/java/neqsim/thermo/phase/PhaseDesmukhMather.java 0.00% 1 Missing ⚠️
...rc/main/java/neqsim/thermo/phase/PhaseDuanSun.java 0.00% 1 Missing ⚠️
src/main/java/neqsim/thermo/phase/PhaseGENRTL.java 0.00% 1 Missing ⚠️
...ava/neqsim/thermo/phase/PhaseGENRTLmodifiedHV.java 50.00% 1 Missing ⚠️
...in/java/neqsim/thermo/phase/PhaseGEUnifacPSRK.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #941   +/-   ##
=========================================
  Coverage     34.69%   34.69%           
- Complexity     5275     5276    +1     
=========================================
  Files           700      700           
  Lines         69716    69716           
  Branches       7984     7984           
=========================================
+ Hits          24185    24186    +1     
  Misses        44049    44049           
+ Partials       1482     1481    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil force-pushed the ref_GE branch 2 times, most recently from 2c75b4a to 4297a56 Compare March 7, 2024 13:02
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like good updates😀

@asmfstatoil asmfstatoil merged commit d71c203 into equinor:master Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants