Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix solid calcs #976

Merged
merged 7 commits into from
Apr 1, 2024
Merged

fix solid calcs #976

merged 7 commits into from
Apr 1, 2024

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Apr 1, 2024

fix solid calcs

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 29.91453% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 34.73%. Comparing base (ae2bc5f) to head (08216d7).

Files Patch % Lines
...c/main/java/neqsim/thermo/system/SystemThermo.java 25.00% 75 Missing ⚠️
...main/java/neqsim/util/database/NeqSimDataBase.java 60.00% 3 Missing and 1 partial ⚠️
...n/java/neqsim/thermo/component/ComponentSolid.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #976      +/-   ##
============================================
+ Coverage     34.71%   34.73%   +0.02%     
- Complexity     5290     5296       +6     
============================================
  Files           700      700              
  Lines         69561    69600      +39     
  Branches       7997     8001       +4     
============================================
+ Hits          24148    24177      +29     
- Misses        43927    43936       +9     
- Partials       1486     1487       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit 7204d95 into master Apr 1, 2024
7 checks passed
@EvenSol EvenSol deleted the fixsol branch April 1, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants