Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more units #983

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Add more units #983

merged 2 commits into from
Apr 21, 2024

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Apr 20, 2024

Improve unit handeling by adding a unit class.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.74684% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 35.03%. Comparing base (3e034e0) to head (cfa8be5).

Files Patch % Lines
src/main/java/neqsim/Units.java 80.00% 8 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 81.81% 4 Missing ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 71.42% 2 Missing ⚠️
src/main/java/neqsim/util/unit/PressureUnit.java 85.71% 1 Missing ⚠️
...rc/main/java/neqsim/util/unit/TemperatureUnit.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #983      +/-   ##
============================================
+ Coverage     34.74%   35.03%   +0.29%     
- Complexity     5296     5332      +36     
============================================
  Files           700      701       +1     
  Lines         69600    69662      +62     
  Branches       8001     8005       +4     
============================================
+ Hits          24184    24408     +224     
+ Misses        43929    43765     -164     
- Partials       1487     1489       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol marked this pull request as ready for review April 21, 2024 08:36
@EvenSol EvenSol merged commit 9443010 into master Apr 21, 2024
9 checks passed
@EvenSol EvenSol deleted the add-more-units branch April 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants