Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more field units #985

Merged
merged 7 commits into from
Apr 21, 2024
Merged

added more field units #985

merged 7 commits into from
Apr 21, 2024

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Apr 21, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 80.24691% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 35.03%. Comparing base (a56409d) to head (a9835d4).

Files Patch % Lines
...c/main/java/neqsim/thermo/system/SystemThermo.java 80.64% 12 Missing ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 68.57% 9 Missing and 2 partials ⚠️
src/main/java/neqsim/util/unit/Units.java 86.15% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #985   +/-   ##
=========================================
  Coverage     35.02%   35.03%           
- Complexity     5334     5339    +5     
=========================================
  Files           701      701           
  Lines         69681    69759   +78     
  Branches       8012     8014    +2     
=========================================
+ Hits          24407    24438   +31     
- Misses        43785    43830   +45     
- Partials       1489     1491    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit bd3e118 into master Apr 21, 2024
7 checks passed
@EvenSol EvenSol deleted the field_units branch April 21, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants