Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first implementation of reporting of process #986

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Apr 21, 2024

Implementation of reporting results from process simulation in json format. Also further work on handling unit formats.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 43.52941% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 35.14%. Comparing base (bd3e118) to head (b6eb87b).

Files Patch % Lines
...cessSimulation/processEquipment/stream/Stream.java 3.22% 30 Missing ⚠️
src/main/java/neqsim/util/unit/Units.java 23.07% 7 Missing and 3 partials ⚠️
...on/processEquipment/ProcessEquipmentBaseClass.java 0.00% 1 Missing ⚠️
...sSimulation/processEquipment/TwoPortEquipment.java 0.00% 1 Missing ⚠️
...ulation/processEquipment/heatExchanger/Cooler.java 0.00% 1 Missing ⚠️
...ulation/processEquipment/heatExchanger/Heater.java 0.00% 1 Missing ⚠️
...rocessEquipment/separator/ThreePhaseSeparator.java 0.00% 1 Missing ⚠️
...processSimulation/processSystem/ProcessModule.java 0.00% 1 Missing ⚠️
...mulation/processSystem/ProcessModuleBaseClass.java 0.00% 1 Missing ⚠️
.../processSimulation/util/monitor/ValveResponse.java 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #986      +/-   ##
============================================
+ Coverage     35.03%   35.14%   +0.10%     
- Complexity     5339     5360      +21     
============================================
  Files           701      703       +2     
  Lines         69765    69846      +81     
  Branches       8014     8016       +2     
============================================
+ Hits          24444    24547     +103     
+ Misses        43830    43794      -36     
- Partials       1491     1505      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol marked this pull request as ready for review April 22, 2024 22:31
@EvenSol EvenSol merged commit 7767de1 into master Apr 22, 2024
9 checks passed
@EvenSol EvenSol deleted the create-process-report branch April 22, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants