Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

987 do not converge recycles at each process simulation #989

Merged

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Apr 23, 2024

implemented method run_step() in ProcessSystem to improve speed of online pseudo steady state simulations.

@EvenSol EvenSol linked an issue Apr 23, 2024 that may be closed by this pull request
@EvenSol EvenSol marked this pull request as ready for review April 23, 2024 18:45
@EvenSol
Copy link
Collaborator Author

EvenSol commented Apr 23, 2024

@Sviatose lets discuss how this can improve calculatioin speed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 35.15%. Comparing base (7767de1) to head (c484e7a).

Files Patch % Lines
...processSimulation/processSystem/ProcessSystem.java 77.77% 2 Missing ⚠️
...on/processEquipment/ProcessEquipmentBaseClass.java 0.00% 1 Missing ⚠️
...processSimulation/processSystem/ProcessModule.java 0.00% 1 Missing ⚠️
...mulation/processSystem/ProcessModuleBaseClass.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #989   +/-   ##
=========================================
  Coverage     35.14%   35.15%           
- Complexity     5360     5364    +4     
=========================================
  Files           703      703           
  Lines         69846    69860   +14     
  Branches       8016     8017    +1     
=========================================
+ Hits          24547    24556    +9     
- Misses        43794    43799    +5     
  Partials       1505     1505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit c87dcf9 into master Apr 23, 2024
9 checks passed
@EvenSol EvenSol deleted the 987-do-not-converge-recycles-at-each-process-simulation branch April 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not converge recycles at each process simulation
2 participants