-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SeismicWriter and Xarray Support #8
Conversation
Great to have some improvements coming into this library - thanks @trhallam ! I have run the tests and get the following errors: MacOS 3.8 Python <=3.9 All others These will need addressing before the PR can be accepted. |
Thanks @da-wad , Python 3.8 is basically at EOL from Q3 this year. Do you think it can be dropped from testing? Also Github runners don't have Python images on Arm64 for Python<=3.10. |
…py-lt-3.10 Address testing pipeline failures.
This should be all ready to go now @da-wad |
The package had no native
SeismicWriter
and would benefit from Xarray support.I have added Lazy Xarray support for opening and writing ZGY files from SEGYSAK. I think it is better placed in this library.
Breaking Changes:
Requires Numpy>1.20
Code Changes:
numpy.bool
depreciation error in openzgy. Fixes np.bool depreceated #5setup.py
topyproject.toml
.Features Added
ds.pyzgy.to_zgy(...)
.Issues: