-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update style setup #615
Merged
Merged
Update style setup #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larsevj
commented
May 23, 2024
•
edited
Loading
edited
- Runs tests in parallel
- Uses only ruff for linting/format instead of flake8, black and isort, and adds new ruff rules
- Installs brew for macos (not-needed yet, but makes it easier to update to macos-latest)
4f5ba64
to
88b8b06
Compare
1f161e2
to
68dcd7d
Compare
68dcd7d
to
6039f56
Compare
e907159
to
6ad60bf
Compare
Think the PR title needs a slight update 😅 |
True, it diverged away from its original purpose. |
6ad60bf
to
dda4a1d
Compare
dda4a1d
to
b92241e
Compare
andreas-el
reviewed
Jun 10, 2024
andreas-el
reviewed
Jun 10, 2024
andreas-el
reviewed
Jun 10, 2024
andreas-el
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems properly done.
Can consider the comments, but hq already. 👍
4236404
to
b349e11
Compare
Also adds more rules to the ruff linter.
b349e11
to
1f4bdae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.