Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style setup #615

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Update style setup #615

merged 3 commits into from
Jun 10, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented May 23, 2024

  • Runs tests in parallel
  • Uses only ruff for linting/format instead of flake8, black and isort, and adds new ruff rules
  • Installs brew for macos (not-needed yet, but makes it easier to update to macos-latest)

@larsevj larsevj force-pushed the investigate_macos_issues branch 3 times, most recently from 4f5ba64 to 88b8b06 Compare May 23, 2024 12:03
@larsevj larsevj enabled auto-merge (rebase) May 23, 2024 12:03
@larsevj larsevj force-pushed the investigate_macos_issues branch 6 times, most recently from 1f161e2 to 68dcd7d Compare May 29, 2024 11:56
@larsevj larsevj disabled auto-merge May 29, 2024 11:56
@larsevj larsevj force-pushed the investigate_macos_issues branch 3 times, most recently from e907159 to 6ad60bf Compare June 4, 2024 12:15
@sondreso
Copy link
Contributor

sondreso commented Jun 6, 2024

Think the PR title needs a slight update 😅

@larsevj
Copy link
Contributor Author

larsevj commented Jun 6, 2024

True, it diverged away from its original purpose.

@larsevj larsevj changed the title Use macos 14 Update style setup Jun 6, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems properly done.
Can consider the comments, but hq already. 👍

@larsevj larsevj force-pushed the investigate_macos_issues branch 2 times, most recently from 4236404 to b349e11 Compare June 10, 2024 15:47
Also adds more rules to the ruff linter.
@larsevj larsevj merged commit 312471b into main Jun 10, 2024
10 checks passed
@larsevj larsevj deleted the investigate_macos_issues branch June 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants