Add support for snapshot readertype #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename stop_time to end_time Make ts=60 default arg value for read()
Make end_time parameter when querying for snapshot.
Slightly better handling of maps implemented. Now passes entire fetched mapdef dict to generate_read_query() instead of simply MAP_HistoryValue. This provides MAP_CurrentTimeStamp and MAP_CurrentValue for fetching snapshots for mapped tags. Cleaned up get_unit() and get_description() while refactoring helpers. The implementation of search() is still rather horrendous, but it needs to be refactored at some point anyway, so leaving it alone for now. All methods called _generate_*_for_search are used by search() only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for calling read() with ReaderType.SNAPSHOT added to all handlers.
Renamed stop_time to end_time.
The read() input arguments start_time, stop_time and ts are now keyword arguments. ts is default 60 (seconds).
For Web based handlers, end_time is an optional argument to snapshot reads. Will fetch a snapshot from the time provided.