Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow raw plot data to be downloaded directly to CSV #70

Closed
DanSava opened this issue Sep 8, 2020 · 3 comments · Fixed by #71
Closed

Allow raw plot data to be downloaded directly to CSV #70

DanSava opened this issue Sep 8, 2020 · 3 comments · Fixed by #71
Projects

Comments

@DanSava
Copy link
Contributor

DanSava commented Sep 8, 2020

Users of Everviz (which is developed on top of Webviz) have expressed the desire to have the ability to download raw plot data directly to CSV and not as a zip file. Would it be possible to have an option between ZIP and raw CSV?

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Sep 9, 2020

This is definitely possible 👍 We actually started with .csv, and moved to .zip when there were (sometimes) need of downloading large files and/or multiple separate files.

Giving the option to plugin authors to define zip/csv/others(?) sounds reasonable.

We might, if possible, want to also look into moving away from using data-uri: in the implementation, and instead send the files directly with flask (the tricky part here could be that the data to be downloaded generally is not static, but "filtered"/selected by the user, and therefore "created" on demand and depends on the state in the front-end...might be some ideas here). Alternatively, if not prioritized now to move away from data-uri:, we could for now document what roughly the file size limit is (when using data-uri:) to plugin authors.

@anders-kiaer anders-kiaer added this to Backlog in Webviz via automation Sep 9, 2020
@anders-kiaer anders-kiaer moved this from Backlog to Prioritized (next in progress) in Webviz Sep 9, 2020
@DanSava
Copy link
Contributor Author

DanSava commented Sep 9, 2020

We might, if possible, want to also look into moving away from using data-uri: in the implementation, and instead send the files directly with flask

That is an interesting idea but would it be possible to solve it in a different issue? If that is the case I have an implementation suggestion in #71

@anders-kiaer
Copy link
Collaborator

That is an interesting idea but would it be possible to solve it in a different issue?

Yes, that could be a separate issue and PR.

Webviz automation moved this from Prioritized (next in progress) to Done Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Webviz
  
Done 🏁
Development

Successfully merging a pull request may close this issue.

2 participants