Allow plugin to define type of downloaded file

[DanSava]

Closes #70

[DanSava]

I could not find a suggestion on how the zip download is being tested so this PR does not contain any testing for the new functionality. I only did manual testing 😞

If this is approved and merged I will follow it up with a related issue and PR in webviz-config.

[anders-kiaer]

Thanks for the PR @DanSava 🎉

I could not find a suggestion on how the zip download is being tested so this PR does not contain any testing for the new functionality. I only did manual testing.

That is totally fine - we do not have an 🤖 integration test for the (zip) download button as of now.

If this is approved and merged I will follow it up with a related issue and PR in webviz-config.

We will get something like this in, but I'm thinking instead of adding a new special case (.csv) in addition to the existing special case (.zip), maybe we could simply remove the references to csv/zip altogether in webviz-core-components, and let plugin authors define what file type is to be downloaded? That also keeps the code base a bit smaller. Generally, in the future, I guess it could be basically anything that is downloaded from a plugin (SEGY cube behind some seismic intersection, some other binary domain specific file...).

Adding the possibility of choosing filename from plugin side is a nice extra change, good idea 👍 As well as changing download button icon to the more generic faDawnload.

Breaking changes in webviz-core-components can most probably be transformed into deprecation warnings in the only package (webviz-config) directly using webviz-core-components, so that is no problem in this repository.

Opinions on this @DanSava and @HansKallekleiv?

[DanSava]

I'm thinking instead of adding a new special case (.csv) in addition to the existing special case (.zip), maybe we could simply remove the references to csv/zip altogether in webviz-core-components, and let plugin authors define what file type is to be downloaded?

I think this is a good idea

One small issue I can think about is that once there is only a general way of downloading a plot resource like csv or zip it will not be possible to implement both like have a separate button for zip and a another button for csv. But it is hard for me to estimate if this is something that users would want to have even in our application, so maybe it is not an issue at all.

[HansKallekleiv]

I agree. Handling this from the plugin side is better 👍

[anders-kiaer]

LGTM! 🚀 Some minor comments to consider below, otherwise I think this is ready. 👍

Maybe most efficient to keep this PR open/unmerged until a corresponding webviz-config PR is made, in case it becomes obvious that some adjustments in this PR would be useful.

[anders-kiaer]

Thanks for the changes both here and in the related webviz-config PR @DanSava - looks nice. Done some small further changes in separate commit (for now) - shout out if you don't agree @DanSava. 📢

@HansKallekleiv: can you do a final review on this one? ✔️ Then we'll merge and release a new version of webviz-core-components such that the version in webviz-config's setup.py can be properly bumped, as well as webviz-config CI becomes 🟢.

[DanSava]

The changes look good to me 👍 thanks for making them!

[HansKallekleiv]

Looks good! 👍