fix: do not display "Loading assets" feedback when isRenderedCallback exists #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists. The client code can handle the assets loading feedback on its own using isRenderedCallback. This way it can control the look, feel and layout of this feedback, and will prevent possible inference with application own components. BTW, center this feedback. Viewers team has an example where the feedback component does move the application components...
w1nklr
changed the title
hkfb
reviewed
Jan 19, 2024
Change default loading feedback to be at bottom right
LeonidPolukhin
approved these changes
Jan 22, 2024
hkfb
pushed a commit
that referenced
this pull request
Jan 22, 2024
## [0.13.6](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.13.5...subsurface-viewer@0.13.6) (2024-01-22) ### Bug Fixes * do not display "Loading assets" feedback when isRenderedCallback exists ([#1882](#1882)) ([12431d8](12431d8))
|
🎉 This issue has been resolved in version subsurface-viewer@0.13.6 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client code can handle the assets loading feedback on its own using isRenderedCallback. This way it can control the look, feel and layout of this feedback, and will prevent possible inference with application own components.
BTW, this default feedback gets centered in the PR.
Viewers team has an example where the feedback component does move the application components...