Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not display "Loading assets" feedback when isRenderedCallback exists #1882

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix: do not display "Loading assets" feedback when isRenderedCallback exists #1882

merged 5 commits into from
Jan 22, 2024

Commits on Jan 19, 2024

  1. Do not display "Loading assets..." feedback when isRenderedCallback e… 

    …xists.

The client code can handle the assets loading feedback on its own using isRenderedCallback.
This way it can control the look, feel and layout of this feedback, and will prevent
possible inference with application own components.

BTW, center this feedback.

Viewers team has an example where the feedback component does move the application components...
    @w1nklr
    w1nklr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f4bb765 View commit details
    Browse the repository at this point in the history

  2. Update test snapshots

    @w1nklr
    w1nklr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e9c1398 View commit details
    Browse the repository at this point in the history

  3. Move to percentage loading callback 

    Change default loading feedback to be at bottom right
    @w1nklr
    w1nklr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e34fc81 View commit details
    Browse the repository at this point in the history

  4. Fix snapshots

    @w1nklr
    w1nklr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    8225131 View commit details
    Browse the repository at this point in the history

  5. Rename onRederedProgress to onRenderingProgress

    @w1nklr
    w1nklr committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e123628 View commit details
    Browse the repository at this point in the history