fix: mapLayer web worker crashes if no property data provded. #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 14, 2023 16:05
LeonidPolukhin
added
bug
nilscb
approved these changes
Jan 30, 2024
w1nklr
reviewed
Jan 30, 2024
| isMesh: boolean, | ||
| frame: Frame, | ||
| smoothShading: boolean, | ||
| gridLines: boolean, | ||
| ]; | ||
|
|
||
| async function loadURLData(url: string): Promise<Float32Array | null> { |
There was a problem hiding this comment.
Shouldn't these function be shared and used in every place where data arrays are loaded ?
There was a problem hiding this comment.
Yes, they should be but it's more preferable to refactor in a dedicated PR rather than in this bug fixing one.
hkfb
pushed a commit
that referenced
this pull request
Jan 31, 2024
## [0.14.2](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.14.1...subsurface-viewer@0.14.2) (2024-01-31) ### Bug Fixes * mapLayer web worker crashes if no property data provded. ([#1900](#1900)) ([8cfa9d8](8cfa9d8))
|
🎉 This issue has been resolved in version subsurface-viewer@0.14.2 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash if fixed.
Some mapLayer code refactored.