feat(grid3d): prop to show-hide grid lines added #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidPolukhin
added
enhancement
hkfb
approved these changes
Aug 2, 2023
hkfb
reviewed
Aug 2, 2023
| /** Enable lines around cell faces. | ||
| * default: true. | ||
| */ | ||
| gridLines: boolean; |
There was a problem hiding this comment.
Suggest making gridLines optional with the ? operator
There was a problem hiding this comment.
The same prop isn't optional in triangle layer. For consistency, should all the props of the kind be optional?
There was a problem hiding this comment.
As it touches several layers suggest to make it in a separate task, if you don't mind.
hkfb
pushed a commit
that referenced
this pull request
Sep 20, 2023
# 1.0.0 (2023-09-20) ### Bug Fixes * Improve "isLoadedCallback" to not return true before first draw of layer not only just when data are loaded. ([#1656](#1656)) ([3875f8b](3875f8b)) * MapLayer - null meshData values are treated as 0 [#1642](#1642) ([#1648](#1648)) ([6198bc4](6198bc4)) * wrong export of default as type ([#1645](#1645)) ([77c171b](77c171b)) ### Features * **grid3d:** prop to show-hide grid lines added ([#1624](#1624)) ([0b22788](0b22788))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hkfb
pushed a commit
that referenced
this pull request
Sep 21, 2023
# 1.0.0 (2023-09-21) ### Bug Fixes * Improve "isLoadedCallback" to not return true before first draw of layer not only just when data are loaded. ([#1656](#1656)) ([3875f8b](3875f8b)) * MapLayer - null meshData values are treated as 0 [#1642](#1642) ([#1648](#1648)) ([6198bc4](6198bc4)) * wrong export of default as type ([#1645](#1645)) ([77c171b](77c171b)) ### Features * **grid3d:** prop to show-hide grid lines added ([#1624](#1624)) ([0b22788](0b22788))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hkfb
pushed a commit
that referenced
this pull request
Sep 22, 2023
# 1.0.0 (2023-09-22) ### Bug Fixes * Improve "isLoadedCallback" to not return true before first draw of layer not only just when data are loaded. ([#1656](#1656)) ([3875f8b](3875f8b)) * MapLayer - null meshData values are treated as 0 [#1642](#1642) ([#1648](#1648)) ([6198bc4](6198bc4)) * wrong export of default as type ([#1645](#1645)) ([77c171b](77c171b)) ### Features * **grid3d:** prop to show-hide grid lines added ([#1624](#1624)) ([0b22788](0b22788))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prop "gridLines" added to Grid3d layer.