feat: New wellsLayer property: "simplifiedRendering". Default false. #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If enabled will cause wells to be drawn in simplified mode when rotaing or panning to increase drawing speed. Added new story for gullfaks wells to test large data sets. Also existing "refine" property defect was fixed.
nilscb
changed the title
nilscb
added
AspenTech
nilscb
changed the title
w1nklr
reviewed
Sep 11, 2023
w1nklr
reviewed
Sep 11, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
w1nklr
reviewed
Sep 11, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
nilscb
changed the title
w1nklr
reviewed
Sep 11, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
w1nklr
reviewed
Sep 11, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
hkfb
requested changes
Sep 12, 2023
hkfb
requested changes
Sep 15, 2023
typescript/packages/subsurface-viewer/src/layers/wells/utils/spline.ts
Outdated
Show resolved
Hide resolved
hkfb
reviewed
Sep 15, 2023
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
hkfb
reviewed
Sep 19, 2023
typescript/packages/subsurface-viewer/src/layers/wells/utils/spline.ts
Outdated
Show resolved
Hide resolved
|
The well trajectories appear as ribbons but not always facing the camera. Is it necessary for performance to disable billboard rendering? Also, the well heads now appear as horizontal discs. Also, observe some strange artifacts along some trajectories, especially the most vertical ones:
|
hkfb
changed the title
hkfb
pushed a commit
that referenced
this pull request
Sep 22, 2023
# [0.2.0](https://github.com/equinor/webviz-subsurface-components/compare/wsc-common@0.1.0...wsc-common@0.2.0) (2023-09-22) ### Features * New wellsLayer property: "simplifiedRendering". Default false. ([#1653](#1653)) ([baffae1](baffae1))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hkfb
pushed a commit
that referenced
this pull request
Sep 22, 2023
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hkfb
pushed a commit
that referenced
this pull request
Sep 22, 2023
# [0.2.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.1.1...subsurface-viewer@0.2.0) (2023-09-22) ### Features * New wellsLayer property: "simplifiedRendering". Default false. ([#1653](#1653)) ([baffae1](baffae1))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hkfb
pushed a commit
that referenced
this pull request
Sep 22, 2023
# [1.1.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.0.0...well-log-viewer@1.1.0) (2023-09-22) ### Features * New wellsLayer property: "simplifiedRendering". Default false. ([#1653](#1653)) ([baffae1](baffae1))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hkfb
pushed a commit
that referenced
this pull request
Sep 22, 2023
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
nilscb
pushed a commit
to nilscb/webviz-subsurface-components
that referenced
this pull request
Sep 26, 2023
… triggered when deck.gl receives an empty layer list. * New wellsLayer property: "simplifiedRendering". Default false. ([equinor#1653](equinor#1653)) ([baffae1](equinor@baffae1))
nilscb
added a commit
that referenced
this pull request
Sep 27, 2023
…e… (#1668) * fix: Rename calback to more descriptive name. Also callback should be triggered when deck.gl receives an empty layer list. * New wellsLayer property: "simplifiedRendering". Default false. ([#1653](#1653)) ([baffae1](baffae1)) * Code review comments fixes. --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
hkfb
pushed a commit
that referenced
this pull request
Dec 12, 2023
# 1.0.0 (2023-12-12) ### Bug Fixes * audit fix prod dependencies ([#1707](#1707)) ([b5dbcf8](b5dbcf8)) * bump [@deck](https://github.com/deck).gl/core from 8.9.31 to 8.9.32 in /typescript ([#1764](#1764)) ([5ab32b0](5ab32b0)) * bump @equinor/eds-core-react from 0.32.x to 0.33.0 ([#1704](#1704)) ([75c5de8](75c5de8)) * bump @equinor/videx-wellog from 0.8.0 to 0.8.1 in /typescript ([#1811](#1811)) ([0e6a423](0e6a423)) * bump d3-format from 1.4.5 to 3.1.0 in /typescript ([#1680](#1680)) ([91f42d1](91f42d1)) * bump deck.gl from 8.9.31 to 8.9.32 in /typescript ([#1800](#1800)) ([393230c](393230c)) * bump to latest @emerson-eps/color-tables ([#1770](#1770)) ([e67a285](e67a285)) ### Features * New wellsLayer property: "simplifiedRendering". Default false. ([#1653](#1653)) ([baffae1](baffae1)) * Split GroupTree into GroupTreePlot-component and settings ([#1794](#1794)) ([ef07441](ef07441))
|
🎉 This issue has been resolved in version group-tree-plot@1.0.0 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If enabled will cause wells to be drawn in simplified mode when rotaing or panning to increase drawing speed.
Added new story for gullfaks wells to test large data sets.
Also existing "refine" property defect was fixed.