Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master failing with Dash 1.11 #317

Closed
anders-kiaer opened this issue Apr 24, 2020 · 1 comment · Fixed by #322
Closed

Master failing with Dash 1.11 #317

anders-kiaer opened this issue Apr 24, 2020 · 1 comment · Fixed by #322
Assignees
Projects

Comments

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Apr 24, 2020

Suddenly the master branch is failing, due to timeout on one of the subsurface surface tests.

Investigate what has changed, and if it is needed to increase the timeout.

One way of 🔍 investigation could be to start with comparing versions used of upstream packages (use the printed CI lists of installed software from a successfull run, and a failed run, and compare).

    def test_surface_selector(dash_duo):
    
        app = dash.Dash(__name__)
        app.config.suppress_callback_exceptions = True
        realizations = pd.read_csv("tests/data/realizations.csv")
        s = SurfaceSelector(app, surface_context, realizations)
    
        app.layout = html.Div(children=[s.layout, html.Pre(id="pre", children="ok")])
    
        @app.callback(Output("pre", "children"), [Input(s.storage_id, "children")])
        def _test(data):
            return json.dumps(json.loads(data))
    
        dash_duo.start_server(app)
    
>       dash_duo.wait_for_contains_text("#pre", json.dumps(return_value), timeout=4)
@HansKallekleiv
Copy link
Collaborator

HansKallekleiv commented Apr 24, 2020

This is due to changes in the Dash callback pipeline introduced in Dash 1.11.

There are multiple issues going on here, so far identified:

@HansKallekleiv HansKallekleiv changed the title Master failing Master failing with Dash 1.11 Apr 24, 2020
@HansKallekleiv HansKallekleiv added the blocked ⏳ Blocked by some other software label Apr 24, 2020
This was referenced Apr 24, 2020
@HansKallekleiv HansKallekleiv removed the blocked ⏳ Blocked by some other software label Apr 26, 2020
@anders-kiaer anders-kiaer added this to In Progress in Webviz Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Webviz
  
In Progress 🚧
Development

Successfully merging a pull request may close this issue.

2 participants