Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dash 1.11 #318

Closed
wants to merge 16 commits into from
Closed

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Apr 24, 2020

Replaced by #322

@HansKallekleiv HansKallekleiv marked this pull request as draft April 24, 2020 14:42
@HansKallekleiv HansKallekleiv changed the title Fix master Support Dash 1.11 Apr 26, 2020
@HansKallekleiv HansKallekleiv marked this pull request as ready for review April 26, 2020 12:49
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉 The <= 1.10 limitation was a short-lived one then 👍

Maybe squash the commits in the PR (to reduce repositroy size long term, and also cleaner PR history). Otherwise, LGTM! (One small simplification suggestion added...)

# Redraw figure if ensemble/vector hanges
if ctx == self.ids("ensemble") or ctx == self.ids("vector"):
# Draw initial figure and redraw if ensemble/vector changes
if ctx == self.ids("ensemble") or ctx == self.ids("vector") or ctx == "":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ctx == self.ids("ensemble") or ctx == self.ids("vector") or ctx == "":
if ctx in ["", self.ids("ensemble"), self.ids("vector")]:

@anders-kiaer anders-kiaer added this to In Review in Webviz Apr 27, 2020
Webviz automation moved this from In Review to Done Apr 27, 2020
@HansKallekleiv HansKallekleiv deleted the fix-317 branch April 27, 2020 15:51
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Webviz
  
Done 🏁
Development

Successfully merging this pull request may close these issues.

None yet

2 participants