-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Dash 1.11 #318
Support Dash 1.11 #318
Conversation
Conflicts: setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🎉 The <= 1.10
limitation was a short-lived one then 👍
Maybe squash the commits in the PR (to reduce repositroy size long term, and also cleaner PR history). Otherwise, LGTM! (One small simplification suggestion added...)
# Redraw figure if ensemble/vector hanges | ||
if ctx == self.ids("ensemble") or ctx == self.ids("vector"): | ||
# Draw initial figure and redraw if ensemble/vector changes | ||
if ctx == self.ids("ensemble") or ctx == self.ids("vector") or ctx == "": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ctx == self.ids("ensemble") or ctx == self.ids("vector") or ctx == "": | |
if ctx in ["", self.ids("ensemble"), self.ids("vector")]: |
Replaced by #322