Pvt issue 1202 #1212
Merged
Pvt issue 1202 #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenthoms
approved these changes
Apr 25, 2023
Comment on lines
+92
to
+95
| # data_frame = data_frame.sort_values( | ||
| # ["PRESSURE", "VOLUMEFACTOR", "VISCOSITY"], | ||
| # ascending=[True, True, True], | ||
| # ) |
There was a problem hiding this comment.
If I remember correctly this was only to ensure that the list is sorted and that the points plotted are connected with lines in the correct order (under the assumption that Plotly is plotting in the order given by the input array). This might not have an effect since the data frame might already be sorted beforehand. However, I wonder if the plots would still be correct if the df wasn't. If we are 100% sure that the df is always sorted correctly, this can be removed.
anders-kiaer
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
Contributor checklist
PvtPlot聽#1202.CHANGELOG.md, and added it if should be communicated there.