Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes in VolumetricAnalysis #1223

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Bugfixes in VolumetricAnalysis #1223

merged 2 commits into from
Jun 7, 2023

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Jun 7, 2023

This PR fixes some bugs in the VolumetricAnalysis plugin:

  • Bug in the statistics table that made the selector columns be merged. Bug introduced in Fix pandas FutureWarnings #1116
    image
  • Error was raised when no groups were selected for a bar chart
  • Runtime warning was given when statistics was run on a column with only nan values

@tnatt tnatt added the bug 🐛 Something isn't working label Jun 7, 2023
@tnatt tnatt requested a review from HansKallekleiv June 7, 2023 08:21
@tnatt tnatt self-assigned this Jun 7, 2023
HansKallekleiv
HansKallekleiv approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tnatt tnatt merged commit bc3db13 into equinor:master Jun 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

Assignees

@tnatt tnatt

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tnatt @HansKallekleiv