Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when grouping on FACIES for non-standard static sources #1287

Merged
merged 1 commit into from
May 16, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented May 8, 2024

PR to fix a bug where users would get an KeyError on BULK if the csv-file contained FACIES but did not contain BULK.
Typically this would happen for non-standard static sources where BULK_OIL and BULG_GAS columns are kept.

@tnatt tnatt requested a review from rnyb May 8, 2024 13:01
@tnatt tnatt force-pushed the bugfix_facies_fraction branch 2 times, most recently from baff0a6 to 3117d55 Compare May 8, 2024 13:07
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andreas-el
Copy link
Contributor

I think it makes sense to pin pylint < 3.2.0 to avoid all this for the time being.
I have done so in my current PR, and already created an issue for resolving the pylint issues down the line.
Ref; #1292

@tnatt
Copy link
Collaborator Author

tnatt commented May 16, 2024

I think it makes sense to pin pylint < 3.2.0 to avoid all this for the time being. I have done so in my current PR, and already created an issue for resolving the pylint issues down the line. Ref; #1292

Thanks for letting me know @andreas-el! Yes, I saw your issue briefly and figured I just wait it out and see if you were going to address it soon 😄 But then I'll just pin it instead for the time being 👍

@tnatt tnatt merged commit c3109ec into equinor:master May 16, 2024
5 checks passed
@tnatt tnatt deleted the bugfix_facies_fraction branch May 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants