Add column with total oil/gas volumes to VolumetricAnalysis #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnyb
approved these changes
May 21, 2024
| # create HC_TOTAL columns | ||
| if "STOIIP" in self._dataframe and "ASSOCIATEDOIL" in self._dataframe: | ||
| self._dataframe["STOIIP_TOTAL"] = self._dataframe["STOIIP"].fillna( | ||
| 0 |
There was a problem hiding this comment.
is the fillna(0) split needed here?
There was a problem hiding this comment.
Yes it is due to e.g. the STOIIP being nan for FLUID_ZONE != "oil".. so need to fill it before adding them together otherwise the resulting STOIIP_TOTAL is also nan 🙂
| ) + self._dataframe["ASSOCIATEDOIL"].fillna(0) | ||
| if "GIIP" in self._dataframe and "ASSOCIATEDGAS" in self._dataframe: | ||
| self._dataframe["GIIP_TOTAL"] = self._dataframe["GIIP"].fillna( | ||
| 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic calculation of
STOIIP_TOTALandGIIP_TOTALcolumns toVolumetricAnalysis.Drogon example:
Also included a bugfix on the logic for evaluating if the data is compatible for a water fall plot