Unpin pytables version for Python 3.8 #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we may need to brew install hdf5 on the macOS build runners, too, as an additional (and conditional on the OS) step. In this workflow xtgeo/.github/workflows/publish.yml Line 21 in b06ccbe It is probably a good opportunity to address #1186 at the same time. We can go over some of the details tomorrow. |
ErichSuter
force-pushed
the
unpin-pytables
branch
from
5cee626
to
54943d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1188 +/- ##
=======================================
Coverage 80.02% 80.02%
=======================================
Files 98 98
Lines 13680 13680
Branches 2203 2203
=======================================
Hits 10948 10948
Misses 1999 1999
Partials 733 733 ☔ View full report in Codecov by Sentry. |
ErichSuter
force-pushed
the
unpin-pytables
branch
from
0d5acdb
to
7b20f37
Compare
mferrera
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #937