Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove MacOS latest xlarge runner #1191

Merged

Conversation

ErichSuter
Copy link
Contributor

@ErichSuter ErichSuter commented Apr 8, 2024

Resolves #1186

@ErichSuter ErichSuter self-assigned this Apr 8, 2024
@ErichSuter ErichSuter marked this pull request as ready for review April 8, 2024 13:35
@ErichSuter ErichSuter requested a review from mferrera April 8, 2024 13:36
Copy link
Contributor

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the correct combo is; may need to play around with it a few times

@@ -18,10 +18,6 @@ jobs:
- [ubuntu-latest, manylinux_x86_64]
- [windows-latest, win_amd64]
- [macos-latest, macosx_x86_64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [macos-latest, macosx_x86_64]
- [macos-latest, macosx_x86_64]
- [macos-latest, macosx_arm64]

I think the issue I wrote was misleading here... we still need to build for arm64, we just don't want to do it with the xlarge runner. This might take a few tries futzing with GitHub CI for it to work. It might also still need to exclude python 3.9... but we should try again without excluding it

@ErichSuter ErichSuter force-pushed the remove-macos-latest-xlarge-runner branch 2 times, most recently from 82cbd77 to eddfdfb Compare April 9, 2024 11:53
@ErichSuter ErichSuter force-pushed the remove-macos-latest-xlarge-runner branch from eddfdfb to 1e6b734 Compare April 9, 2024 14:21
Copy link
Contributor

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to go.

Don't worry about the two hanging jobs. In repository settings we have marked CIBW Python cp39 on macos-latest and CIBW Python cp39 on windows-latest as required... but because of the name change

name: CIBW Python ${{ matrix.cibw_python }} on ${{ matrix.os_arch[0] }}-${{ matrix.os_arch[1] }}

these jobs no longer exist. They were replaced by CIBW Python cp39 on macos-latest-macosx_x86_64 and CIBW Python cp39 on windows-latest-win_amd64. Another fun quirk of working with actions: they won't be run at all, but GitHub can't tell that they never will be, so it will wait and expect them to start for x hours.

These can only be adjusted in the repository settings after the PR is merged; I'll take care of it.

@mferrera mferrera merged commit 0375fed into equinor:main Apr 9, 2024
40 checks passed
@mferrera
Copy link
Contributor

mferrera commented Apr 9, 2024

(You may not have been able to bypass the merge requirements so I took it in)

@ErichSuter
Copy link
Contributor Author

OK, thanks :-)

@ErichSuter ErichSuter deleted the remove-macos-latest-xlarge-runner branch April 9, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from macos-latest-xlarge runner
2 participants