Roxar api add new features #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jcrivenaes
force-pushed
the
roxar-api-add-new-features
branch
from
76018a1
to
b41938f
Compare
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
- Coverage 80.83% 80.76% -0.07%
==========================================
Files 83 83
Lines 12678 12671 -7
Branches 2119 2120 +1
==========================================
- Hits 10248 10234 -14
- Misses 1756 1763 +7
Partials 674 674
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jcrivenaes
force-pushed
the
roxar-api-add-new-features
branch
from
0eaabda
to
bcf7b2a
Compare
eivindjahren
requested changes
Jun 17, 2022
jcrivenaes
force-pushed
the
roxar-api-add-new-features
branch
from
bcf7b2a
to
773d33b
Compare
Setting float precision in output files is actually not a good idea, as it restricts precision in particular for Z column that may contain other values than depth (e.g. porosity). Also columns shall be numerical if possible.
Support Roxar API support for "RMS General 2D data" for points, polygons and regular surfaces when RoxAPI version >= 1.6 (RMS13+). For surfaces, also Trends are supported. Also, from Roxar API version 1.6, setting and getting points (and polygons) attributes are supported. In earlier versions, xtgeo use a file workaround which is much slower. Polygon attributes are not implemented in this PR.
jcrivenaes
force-pushed
the
roxar-api-add-new-features
branch
from
e6e6d25
to
e8c8536
Compare
eivindjahren
approved these changes
Jun 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has several commits targeted to Roxar API:
RegularSurface()and_XYZ()based classessave()+load()have been implemented, which should still work for Roxar API < 1.6. Polygons support is postponed.