Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST3 Build 3143 breaks active tab underline #1180

Closed
1 of 3 tasks
anchnk opened this issue Sep 13, 2017 · 13 comments
Closed
1 of 3 tasks

ST3 Build 3143 breaks active tab underline #1180

anchnk opened this issue Sep 13, 2017 · 13 comments

Comments

@anchnk
Copy link

anchnk commented Sep 13, 2017

Summary

ST3 build 3143 breaks UI on my machine. Active tabs underline isn't matching the accent color used in preferences. That's the only quirk I have been able to spot migrating from 3126 to 3143.

Config

Here's my current configuration, which didn't change between the 2 releases:

{
	"color_scheme": "Packages/User/SublimeLinter/Dracula (SL).tmTheme",
	"dpi_scale": 1.0,
	"drag_text": false,
	"font_face": "SauceCodePro Nerd Font",
	"font_options":
	[
		"gray_antialias",
		"subpixel_antialias"
	],
	"font_size": 11,
	"ignored_packages":
	[
		"Vintage"
	],
	"indent_guide_options":
	[
		"draw_normal",
		"draw_active"
	],
	"line_padding_bottom": 1,
	"line_padding_top": 1,
	"material_theme_accent_cyan": true,
	"material_theme_accent_scrollbars": true,
	"material_theme_appbar_charcoal": true,
	"material_theme_arrow_folders": true,
	"material_theme_bright_scrollbars": true,
	"material_theme_bullet_tree_indicator": true,
	"material_theme_contrast_mode": true,
	"material_theme_panel_separator": true,
	"material_theme_small_statusbar": true,
	"overlay_scroll_bars": "enabled",
	"show_encoding": true,
	"sidebar_row_padding_medium": true,
	"sidebar_size_13": true,
	"tab_size": 2,
	"tabs_label_not_italic": true,
	"tabs_medium": false,
	"tabs_small": false,
	"theme": "Material-Theme-Palenight.sublime-theme",
	"translate_tabs_to_spaces": true,
	"word_wrap": true
}

Expected behavior

st3-material-build-3126

Actual behavior

st3-material-build-3143

Steps to reproduce

  1. Upgrade from 3126 to 3143
  2. Restart ST3

Environment

  • Operating system and version:
    • Windows ...
    • Mac OS ...
    • Linux (Ubuntu 16.04 LTS)
  • Sublime Text:
    • Build 3143
  • Material Theme release:
    • v4.0.10
@equinusocio
Copy link
Member

equinusocio commented Sep 13, 2017

Are you on a @3x pixel density device?

@anchnk
Copy link
Author

anchnk commented Sep 13, 2017

I don't think so but I not really sure. My monitor is a LenovoThinkVision E232.

@equinusocio
Copy link
Member

equinusocio commented Sep 13, 2017

@anchnk try here:
http://dpi.lv/
and here
https://www.infobyip.com/detectmonitordpi.php

and report both values

@anchnk
Copy link
Author

anchnk commented Sep 13, 2017

  1. http://dpi.lv: 166 pixels per inch
  2. https://www.infobyip.com/detectmonitordpi.php: Your monitor DPI: 96 x 96

@equinusocio
Copy link
Member

equinusocio commented Sep 13, 2017

mm so you are on a @1x device and this is strange because this kind of issues occurs when ST load an asset with a different/lower resolution than your monitor. At the moment Material Theme provide assets for @1x and @2x.

@istratos
Copy link

istratos commented Sep 14, 2017

The same thing is happening for me as well on 148 pixels per inch and 96 x 96 according to those websites.
OS: Windows 10 64 bits.
Sublime: 3143
Material Theme: 4.0.10

@equinusocio
Copy link
Member

equinusocio commented Sep 15, 2017

Hi, here the release note from the dev channel:
screen shot 2017-09-15 at 09 23 42

I thinks this issue can be related to the first fix. If you can try this build let me know.

@anchnk
Copy link
Author

anchnk commented Sep 15, 2017

I tried it but no luck, same issue

@shawjak3
Copy link

shawjak3 commented Sep 15, 2017

I am also experiencing this behavior since the release of Sublime Text 3 earlier this week.

166ppi
96x96dpi
Mac OS Sierra
Sublime 3143
Material Theme 4.0.10

@dotKev
Copy link

dotKev commented Sep 20, 2017

I have the same issue, but I end up with two different tab styles on the same screen.
st-material-tab
screen shot 2017-09-20 at 11 18 34 am

  • 96x96 dpi
  • 221 ppi
  • Mac OS Sierra
  • Sublime Text: 3143
  • Platform: osx
  • Arch: x64
  • Theme: 4.0.10
  • Install via PC: True
  • Dependencies:
    • mdpopups: 2.1.1
    • markdown: 2.6.9
    • pygments: 2.1a0
    • jinja2: 2.8

@anchnk
Copy link
Author

anchnk commented Oct 26, 2017

Is the referenced commit fixing the issue ? Has it been shipped yet ? I did upgrade my packages today but I still have the issue even though ST3 told me it updated the theme

@equinusocio equinusocio reopened this Oct 26, 2017
@equinusocio
Copy link
Member

Sorry wrong reference

@equinusocio
Copy link
Member

This theme is now deprecated and no more under active development. I'm open to proposals and PR's. If someone want to collaborate and rewrite this theme let me know. For now, consider switching to a not-obsolete editor like Visual Studio Code with Material Theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants