Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme not activating after installation #1230

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Fix theme not activating after installation #1230

merged 1 commit into from
Mar 16, 2018

Conversation

zpreston123
Copy link
Contributor

@zpreston123 zpreston123 commented Mar 16, 2018

Description

Updated the dependencies JSON file to add missing dependencies required by the latest version of mdpopups.

Motivation and Context

This fixes the issue not enabling theme activation after installation, which many users have experienced using the latest version of Sublime.

#1229

How Has This Been Tested?

This was tested by removing the theme's dependencies in the Packages folder, which disabled theme activation and other options in the Preferences -> Package Settings -> Material Theme menu, except the advanced configuration option. Then, I restarted Sublime a few times and Package Control installed those dependencies automatically. This enabled the greyed out menu options as a result.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

mdpopups was missing pymdownx and pyyaml dependencies
@equinusocio equinusocio merged commit 1e8ffa5 into material-theme:develop Mar 16, 2018
@zpreston123 zpreston123 deleted the fix/theme-activation branch March 17, 2018 22:48
@simondell
Copy link

Is this the place to report that

  1. I never had this problem (not an issue in itself, but stated for context)
  2. now the problem is "solved", I have the problem.

@zpreston123
Copy link
Contributor Author

zpreston123 commented Mar 24, 2018

@simondell Check the Packages folder and see if pymdownx and pyyaml dependencies were installed. Otherwise, restart Sublime and wait for Package Control to install them automatically; may require a couple of restarts before it happens.

If the problem persists, please leave a comment in issue #1229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants