-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material Theme should not define anchors as block #939
Comments
I think the generated image should be inline-block to fix this. Anyway i can only use inline-block, not inline |
I don't see why you would need to modify the default anchor tag at all? I don't use Material Theme, and I was only posting this in behalf of the affected party, but now I am curious why the default anchor formatting is not sufficient? Granted any plugin can wrap their content and force anchors back to however they want, but why enforce block? |
Oh, FYI, inline-block is not supported by Sublime's minihtml. |
Because display block or inline block allows paddings and margins and i useful to avoid containers. I will investigate, thanks. |
Summary
Currently Material Theme is defining links as
display: block
. This should not be done. As a default, this doesn't make sense. Anchor tags are inline and should be treated as such. This is breaking popups for people where images are wrapped in links. See: facelessuser/ColorHelper#52. I could override this, but I shouldn't have to.Steps to reproduce
ColorHelper: Show Color Picker
command from the palette. All links are now blocks and images disappear if they are wrapped in blocks.Environment
The text was updated successfully, but these errors were encountered: