Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Theme should not define anchors as block #939

Closed
facelessuser opened this issue Aug 4, 2016 · 4 comments
Closed

Material Theme should not define anchors as block #939

facelessuser opened this issue Aug 4, 2016 · 4 comments

Comments

@facelessuser
Copy link

facelessuser commented Aug 4, 2016

Summary

Currently Material Theme is defining links as display: block. This should not be done. As a default, this doesn't make sense. Anchor tags are inline and should be treated as such. This is breaking popups for people where images are wrapped in links. See: facelessuser/ColorHelper#52. I could override this, but I shouldn't have to.

Steps to reproduce

  1. Install ColorHelper via Package Control and restart.
  2. Initiate the ColorHelper: Show Color Picker command from the palette. All links are now blocks and images disappear if they are wrapped in blocks.

Environment

  • Operating system and version:
    • All
  • Sublime Text:
    • 3120
  • Material Theme release:
    • Current
@equinusocio
Copy link
Member

I think the generated image should be inline-block to fix this. Anyway i can only use inline-block, not inline

@facelessuser
Copy link
Author

I don't see why you would need to modify the default anchor tag at all? I don't use Material Theme, and I was only posting this in behalf of the affected party, but now I am curious why the default anchor formatting is not sufficient? Granted any plugin can wrap their content and force anchors back to however they want, but why enforce block?

@facelessuser
Copy link
Author

Oh, FYI, inline-block is not supported by Sublime's minihtml.

@equinusocio
Copy link
Member

Because display block or inline block allows paddings and margins and i useful to avoid containers. I will investigate, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants