Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder icons are not pixel-fitted #958

Closed
chanpory opened this issue Aug 15, 2016 · 8 comments
Closed

Folder icons are not pixel-fitted #958

chanpory opened this issue Aug 15, 2016 · 8 comments

Comments

@chanpory
Copy link

On a non-retina external monitor, the folder icons are slightly blurry and not pixel-fitted to be sharp.

@equinusocio
Copy link
Member

Only these icons are blurry? Anyway i can't handle this behavior because Sublime Text detect the assets resolution to use. So on a retina display it will use @2x images and on a non-retina display it will use the default @1x images. Both resolutions are available and probably ST fail to use both @1x and @2x when you use an external monitor with a different pixel density. I'm sorry, maybe you can report this issue on the official ST forum.

@chanpory
Copy link
Author

@equinusocio I mean that the assets themselves are not aligned to the pixel-grid, so this isn't an issue with ST itself. Here is an example or a blurry asset:

https://github.com/equinusocio/material-theme/blob/develop/assets/accent-blue/folder_opened--hover.png

This might a result of the tool you're using to rasterize the icons. The lines are landing at half pixels causing some blurriness. This occurs on your Retina assets as well, but it's less apparent because of the higher-res. Are you using Sketch, Illustrator, or Photoshop to create the assets?

Here's a bit of info on pixel grids: https://www.smashingmagazine.com/2014/10/create-assets-for-multiple-scale-factors/

Everything else about this theme is sharp, except for the icons.

@equinusocio
Copy link
Member

You're right. I will fix these icons.

@enkia
Copy link

enkia commented Sep 5, 2016

@equinusocio I've pixel fitted the icons in Sketch but it seems to me that when doing so, it changes the original design of the 'opened folder' material icon. The border is thinner on Retina screens than I'd like.

Thoughts? You can test accent-blue using these icons.

@equinusocio
Copy link
Member

equinusocio commented Oct 4, 2016

@enkia You have to multiply. So if on a normal display the folder icon have 2px border on a retina display the border should be 4px, not 1px.

@enkia
Copy link

enkia commented Oct 4, 2016

I tried true 2x borders at first but it was too thick in my estimation. For my own version of your theme, I settled on 1px in the end.

@equinusocio
Copy link
Member

equinusocio commented Oct 4, 2016

Ok.. so you're working on your own theme version? Ook, I will do it.

@enkia
Copy link

enkia commented Oct 4, 2016

Yeah, I mentioned it awhile back. :) It's up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants