model.dup should copy model values with nil public_uid #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curent imlplementation:
this should be:
Why?
read more: https://blog.appsignal.com/2019/02/26/diving-into-dup-and-clone.html
important part:
Rails implement it same way
https://github.com/rails/rails/blob/85f45350e6d3fb6284c744d36b77b79ce639dfee/activerecord/lib/active_record/timestamp.rb#L50